Skip to content

Checkstyle Fixes #7170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Checkstyle Fixes #7170

wants to merge 21 commits into from
+186 −82

Conversation

markiantorno
Copy link
Collaborator

  1. All duplicate or missing Msg.code are fixed
  2. All incorrect Nonnull references have been updated
  3. mvn checkstyle:check now runs our checkstyle not the sun_rules.xml default one
  4. Pipeline has been updated to run the new checkstyle check
  5. Pipeline runs checkstyle first before any build or test and fails fast

@robogary
Copy link
Contributor

robogary commented Jul 31, 2025 •
edited
Loading

Formatting check succeeded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fil512 fil512 fil512 approved these changes

@michaelabuckley michaelabuckley Awaiting requested review from michaelabuckley michaelabuckley is a code owner

@jamesagnew jamesagnew Awaiting requested review from jamesagnew jamesagnew is a code owner

@tadgh tadgh Awaiting requested review from tadgh tadgh is a code owner

@nathandoef nathandoef Awaiting requested review from nathandoef nathandoef is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markiantorno @robogary @fil512